Without the double quotes, the $DISK variable expands and will not
handle multi-disk correctly.
Co-authored-by: @baberlevi
Signed-off-by: Maurice Zhou <ja@apvc.uk>
RPM will prompt to install our signing key, so no need to manually import it:
```
ZFS on Linux for EL9 - kmod 3.3 MB/s | 3.4 kB 00:00
Importing GPG key 0x9DB84141:
Userid : "OpenZFS <release@openzfs.org>"
Fingerprint: 7DC7 299D CF7C 7FD9 CD87 701B A599 FD5E 9DB8 4141
From : /etc/pki/rpm-gpg/RPM-GPG-KEY-openzfs
Is this ok [y/N]: y
```
Removing the line also gets around the problem of the key being renamed from `RPM-GPG-KEY-zfsonlinux` -> `RPM-GPG-KEY-openzfs`
Add our new key for EL9+ and Fedora 37+, and update instructions
to include EL9. Also update links for Fedora/EL to use the
new zfs-release-2-2 RPM.
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Earlier we had to revert the CentOS 7 zfs-release RPM to point to the older `zfs-release.el8_6` RPM, since the newer universal RPM was encoded with zstd compression (which CentOS 7 didn't support). Since then, we've rebuilt the universal RPM with gzip, so we can use it again.
The source package is zfs-linux, not zfsutils-linux. I had this wrong
in the fix for #314.
Closes#318
Reported-by: Piscium
Signed-off-by: Richard Laager <rlaager@wiktel.com>
We stick to two rules here:
* -o options come before -O
* pool-specific options are wedged in between -o and
-O (e.g. compatibility=grub2)
I don't know if that was a deliberate policy, I'm just trying to guess
what the pattern was
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Signed-off-by: Richard Laager <rlaager@wiktel.com>
This regroups the options passed to zpool create in a more logical
way.
1. the ACL/xattr/dnodesize settings are all on one line, since they
are all related (latter being optimizations because we enable the
former)
2. ashift, autotrim, compression, normalization, relatime are all
independent options that merit their own line for better
visibility, they are also optional and therefore it makes sense to
have them separate
3. canmount, mountpoint and -R are all related as well
This is only a "whitespace" fix: there should be no functional change
to this patch.
I also noted that dnodesize=auto is *not* passed to the bpool cache
creation, even though it's passed to the rpool creation. I suspect
that might be an omission. This also goes to show that ordering those
options consistently makes it easier to spot those errors.
This is a followup to #307.
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Signed-off-by: Richard Laager <rlaager@wiktel.com>
According to the apt_preferences man page, we should be able to use
"Package: src:zfsutils-linux". Then we don't have to worry about keeping
the list of packages up-to-date, especially as library soversions change.
Reported-by: udf2457
Closes#314
Signed-off-by: Richard Laager <rlaager@wiktel.com>
This doesn't work on Debian Bullseye. While I tested the actual
create command on unstable, I know I looked at a file list on
packages.debian.org. I must have looked at bullseye-backports by
mistake. That's what I get for not testing the whole thing!
This partially reverts commit 7343c2253f.
Reported-by: anarcat
Closes#309
Signed-off-by: Richard Laager <rlaager@wiktel.com>
The major change for Ubuntu is to mark many of these as optional, like
with Debian and the old guides. As I move away from zsys, this will end
up being more like the old way.
This was also discussed in #306 and #307, but this change has
trade-offs. It can reduce the number of datasets created on the
system, but it does so by increasing the complexity to read and follow
the guide.
Then I just harmonized Debian with Ubuntu. Aside from whitespace,
reordering, rewording, the substantive changes were to drop /opt and
add /var/lib/NetworkManager.
Signed-off-by: Richard Laager <rlaager@wiktel.com>
