From 7343c2253f46fdb00ba272a3f4dcf71b5a326e36 Mon Sep 17 00:00:00 2001 From: Richard Laager Date: Thu, 19 May 2022 22:49:52 -0500 Subject: [PATCH] Debian & Ubuntu: Use compatibility=grub2 This reduces the number of features I need to enable explicitly. As discussed in #306 and #307. Signed-off-by: Richard Laager --- .../Debian/Debian Bullseye Root on ZFS.rst | 17 +++++------------ .../Ubuntu/Ubuntu 22.04 Root on ZFS.rst | 17 +++++------------ 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/docs/Getting Started/Debian/Debian Bullseye Root on ZFS.rst b/docs/Getting Started/Debian/Debian Bullseye Root on ZFS.rst index 974d7cd..b38b3cc 100644 --- a/docs/Getting Started/Debian/Debian Bullseye Root on ZFS.rst +++ b/docs/Getting Started/Debian/Debian Bullseye Root on ZFS.rst @@ -227,19 +227,9 @@ Step 2: Disk Formatting zpool create \ -o cachefile=/etc/zfs/zpool.cache \ - -o ashift=12 -o autotrim=on -d \ - -o feature@async_destroy=enabled \ - -o feature@bookmarks=enabled \ - -o feature@embedded_data=enabled \ - -o feature@empty_bpobj=enabled \ - -o feature@enabled_txg=enabled \ - -o feature@extensible_dataset=enabled \ - -o feature@filesystem_limits=enabled \ - -o feature@hole_birth=enabled \ - -o feature@large_blocks=enabled \ + -o ashift=12 -o autotrim=on \ + -o compatibility=grub2 \ -o feature@livelist=enabled \ - -o feature@lz4_compress=enabled \ - -o feature@spacemap_histogram=enabled \ -o feature@zpool_checkpoint=enabled \ -O acltype=posixacl -O canmount=off -O compression=lz4 \ -O devices=off -O normalization=formD -O relatime=on -O xattr=sa \ @@ -248,6 +238,9 @@ Step 2: Disk Formatting You should not need to customize any of the options for the boot pool. + Ignore the warnings about the features “not in specified 'compatibility' + feature set.” + GRUB does not support all of the zpool features. See ``spa_feature_names`` in `grub-core/fs/zfs/zfs.c `__. diff --git a/docs/Getting Started/Ubuntu/Ubuntu 22.04 Root on ZFS.rst b/docs/Getting Started/Ubuntu/Ubuntu 22.04 Root on ZFS.rst index d15bbef..6c667fa 100644 --- a/docs/Getting Started/Ubuntu/Ubuntu 22.04 Root on ZFS.rst +++ b/docs/Getting Started/Ubuntu/Ubuntu 22.04 Root on ZFS.rst @@ -277,19 +277,9 @@ Step 2: Disk Formatting zpool create \ -o cachefile=/etc/zfs/zpool.cache \ - -o ashift=12 -o autotrim=on -d \ - -o feature@async_destroy=enabled \ - -o feature@bookmarks=enabled \ - -o feature@embedded_data=enabled \ - -o feature@empty_bpobj=enabled \ - -o feature@enabled_txg=enabled \ - -o feature@extensible_dataset=enabled \ - -o feature@filesystem_limits=enabled \ - -o feature@hole_birth=enabled \ - -o feature@large_blocks=enabled \ + -o ashift=12 -o autotrim=on \ + -o compatibility=grub2 \ -o feature@livelist=enabled \ - -o feature@lz4_compress=enabled \ - -o feature@spacemap_histogram=enabled \ -o feature@zpool_checkpoint=enabled \ -O acltype=posixacl -O canmount=off -O compression=lz4 \ -O devices=off -O normalization=formD -O relatime=on -O xattr=sa \ @@ -298,6 +288,9 @@ Step 2: Disk Formatting You should not need to customize any of the options for the boot pool. + Ignore the warnings about the features “not in specified 'compatibility' + feature set.” + GRUB does not support all of the zpool features. See ``spa_feature_names`` in `grub-core/fs/zfs/zfs.c `__.