jacobpascual/keepassxc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve File Dialog

Browse Source 
* QFileDialog returns UNIX paths, even on Windows. This patch converts what QFileDialog returns to the native path format.

* Improve const correctness

* Avoid imposing file extension on Linux

* This patch improves things like unneeded passes by values, missing const qualifiers, ugly copies because of variable reuse and consistency in variable names.
This commit is contained in:
Gianluca Recchia
2019-08-24 17:53:11 +02:00
committed by Jonathan White
parent c12fd369d9
commit fccbb98b8e
6 changed files with 70 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/gui/FileDialog.h
View File

@@ -25,40 +25,36 @@ class FileDialog
public:
QString getOpenFileName(QWidget* parent = nullptr,
const QString& caption = QString(),
QString dir = QString(),
const QString& dir = QString(),
const QString& filter = QString(),
QString* selectedFilter = nullptr,
QFileDialog::Options options = 0);
const QFileDialog::Options options = {});
QStringList getOpenFileNames(QWidget* parent = nullptr,
const QString& caption = QString(),
QString dir = QString(),
const QString& dir = QString(),
const QString& filter = QString(),
QString* selectedFilter = nullptr,
QFileDialog::Options options = 0);
const QFileDialog::Options options = {});
QString getFileName(QWidget* parent = nullptr,
const QString& caption = QString(),
QString dir = QString(),
const QString& dir = QString(),
const QString& filter = QString(),
QString* selectedFilter = nullptr,
QFileDialog::Options options = 0,
const QString& defaultExtension = QString(),
const QString& defaultName = QString());
const QFileDialog::Options options = {});
QString getSaveFileName(QWidget* parent = nullptr,
const QString& caption = QString(),
QString dir = QString(),
const QString& dir = QString(),
const QString& filter = QString(),
QString* selectedFilter = nullptr,
QFileDialog::Options options = 0,
const QString& defaultExtension = QString(),
const QString& defaultName = QString());
const QFileDialog::Options options = {});
QString getExistingDirectory(QWidget* parent = nullptr,
const QString& caption = QString(),
QString dir = QString(),
QFileDialog::Options options = QFileDialog::ShowDirsOnly);
const QString& dir = QString(),
const QFileDialog::Options options = QFileDialog::ShowDirsOnly);
void setNextForgetDialog();
/**