From f5caf3968f57e85eaddf67407190db6d338b4365 Mon Sep 17 00:00:00 2001 From: Aetf Date: Mon, 2 Nov 2020 23:01:04 -0500 Subject: [PATCH] FdoSecrets: fix typos --- src/fdosecrets/objects/Collection.cpp | 11 +++++------ src/fdosecrets/objects/Service.cpp | 8 ++++---- src/fdosecrets/objects/Service.h | 2 +- src/fdosecrets/objects/Session.cpp | 4 ++-- src/fdosecrets/objects/Session.h | 4 ++-- tests/gui/TestGuiFdoSecrets.cpp | 4 ++-- tests/gui/TestGuiFdoSecrets.h | 2 +- 7 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/fdosecrets/objects/Collection.cpp b/src/fdosecrets/objects/Collection.cpp index f03b9209..90d6d9e8 100644 --- a/src/fdosecrets/objects/Collection.cpp +++ b/src/fdosecrets/objects/Collection.cpp @@ -25,7 +25,6 @@ #include "fdosecrets/objects/Session.h" #include "core/Config.h" -#include "core/Database.h" #include "core/Tools.h" #include "gui/DatabaseTabWidget.h" #include "gui/DatabaseWidget.h" @@ -330,12 +329,12 @@ namespace FdoSecrets itemPath = attributes.value(ItemAttributes::PathKey); // check existing item using attributes - auto existings = searchItems(attributes); - if (existings.isError()) { - return existings; + auto existing = searchItems(attributes); + if (existing.isError()) { + return existing; } - if (!existings.value().isEmpty() && replace) { - item = existings.value().front(); + if (!existing.value().isEmpty() && replace) { + item = existing.value().front(); newlyCreated = false; } } diff --git a/src/fdosecrets/objects/Service.cpp b/src/fdosecrets/objects/Service.cpp index 34ace721..2577b476 100644 --- a/src/fdosecrets/objects/Service.cpp +++ b/src/fdosecrets/objects/Service.cpp @@ -54,7 +54,7 @@ namespace FdoSecrets : DBusObject(nullptr) , m_plugin(plugin) , m_databases(std::move(dbTabs)) - , m_insdieEnsureDefaultAlias(false) + , m_insideEnsureDefaultAlias(false) , m_serviceWatcher(nullptr) { connect( @@ -176,11 +176,11 @@ namespace FdoSecrets void Service::ensureDefaultAlias() { - if (m_insdieEnsureDefaultAlias) { + if (m_insideEnsureDefaultAlias) { return; } - m_insdieEnsureDefaultAlias = true; + m_insideEnsureDefaultAlias = true; auto coll = findCollection(m_databases->currentDatabaseWidget()); if (coll) { @@ -188,7 +188,7 @@ namespace FdoSecrets coll->addAlias(DEFAULT_ALIAS).okOrDie(); } - m_insdieEnsureDefaultAlias = false; + m_insideEnsureDefaultAlias = false; } void Service::dbusServiceUnregistered(const QString& service) diff --git a/src/fdosecrets/objects/Service.h b/src/fdosecrets/objects/Service.h index d8d7529d..cf27b277 100644 --- a/src/fdosecrets/objects/Service.h +++ b/src/fdosecrets/objects/Service.h @@ -159,7 +159,7 @@ namespace FdoSecrets QList m_sessions; QHash m_peerToSession; - bool m_insdieEnsureDefaultAlias; + bool m_insideEnsureDefaultAlias; std::unique_ptr m_serviceWatcher; }; diff --git a/src/fdosecrets/objects/Session.cpp b/src/fdosecrets/objects/Session.cpp index 1d502019..26a3c0cf 100644 --- a/src/fdosecrets/objects/Session.cpp +++ b/src/fdosecrets/objects/Session.cpp @@ -24,7 +24,7 @@ namespace FdoSecrets { - QHash Session::negoniationState; + QHash Session::negotiationState; Session* Session::Create(std::unique_ptr&& cipher, const QString& peer, Service* parent) { @@ -57,7 +57,7 @@ namespace FdoSecrets void Session::CleanupNegotiation(const QString& peer) { - negoniationState.remove(peer); + negotiationState.remove(peer); } DBusReturn Session::close() diff --git a/src/fdosecrets/objects/Session.h b/src/fdosecrets/objects/Session.h index 199a7ccc..58b971fc 100644 --- a/src/fdosecrets/objects/Session.h +++ b/src/fdosecrets/objects/Session.h @@ -42,7 +42,7 @@ namespace FdoSecrets public: static std::unique_ptr CreateCiphers(const QString& peer, const QString& algorithm, - const QVariant& intpu, + const QVariant& input, QVariant& output, bool& incomplete); static void CleanupNegotiation(const QString& peer); @@ -99,7 +99,7 @@ namespace FdoSecrets QString m_peer; QUuid m_id; - static QHash negoniationState; + static QHash negotiationState; }; } // namespace FdoSecrets diff --git a/tests/gui/TestGuiFdoSecrets.cpp b/tests/gui/TestGuiFdoSecrets.cpp index e19e6130..af8f32f3 100644 --- a/tests/gui/TestGuiFdoSecrets.cpp +++ b/tests/gui/TestGuiFdoSecrets.cpp @@ -267,7 +267,7 @@ void TestGuiFdoSecrets::init() m_dbWidget = m_tabWidget->currentDatabaseWidget(); m_db = m_dbWidget->database(); - // by default expsoe the root group + // by default expose the root group FdoSecrets::settings()->setExposedGroup(m_db, m_db->rootGroup()->uuid()); QVERIFY(m_dbWidget->save()); } @@ -1047,7 +1047,7 @@ void TestGuiFdoSecrets::testExposeSubgroup() QCOMPARE(exposedEntries, subgroup->entries()); } -void TestGuiFdoSecrets::testModifiyingExposedGroup() +void TestGuiFdoSecrets::testModifyingExposedGroup() { // test when exposed group is removed the collection is not exposed anymore auto subgroup = m_db->rootGroup()->findGroupByPath("/Homebanking"); diff --git a/tests/gui/TestGuiFdoSecrets.h b/tests/gui/TestGuiFdoSecrets.h index 8a961eb8..c4ed108e 100644 --- a/tests/gui/TestGuiFdoSecrets.h +++ b/tests/gui/TestGuiFdoSecrets.h @@ -82,7 +82,7 @@ private slots: void testDefaultAliasAlwaysPresent(); void testExposeSubgroup(); - void testModifiyingExposedGroup(); + void testModifyingExposedGroup(); protected slots: void createDatabaseCallback();