diff --git a/src/gui/ApplicationSettingsWidget.cpp b/src/gui/ApplicationSettingsWidget.cpp index c3cd5e59..fce35223 100644 --- a/src/gui/ApplicationSettingsWidget.cpp +++ b/src/gui/ApplicationSettingsWidget.cpp @@ -100,10 +100,6 @@ ApplicationSettingsWidget::ApplicationSettingsWidget(QWidget* parent) m_generalUi->checkUpdatesSpacer->changeSize(0, 0, QSizePolicy::Fixed, QSizePolicy::Fixed); #endif -#ifndef WITH_XC_KEESHARE - m_generalUi->quietKeeShareSuccess->setVisible(false); -#endif - #ifndef WITH_XC_NETWORKING m_secUi->privacy->setVisible(false); #endif @@ -186,7 +182,6 @@ void ApplicationSettingsWidget::loadSettings() m_generalUi->systrayDarkIconCheckBox->setChecked(config()->get("GUI/DarkTrayIcon").toBool()); m_generalUi->systrayMinimizeToTrayCheckBox->setChecked(config()->get("GUI/MinimizeToTray").toBool()); m_generalUi->minimizeOnCloseCheckBox->setChecked(config()->get("GUI/MinimizeOnClose").toBool()); - m_generalUi->quietKeeShareSuccess->setChecked(config()->get("GUI/QuietKeeShareSuccess").toBool()); m_generalUi->systrayMinimizeOnStartup->setChecked(config()->get("GUI/MinimizeOnStartup").toBool()); m_generalUi->checkForUpdatesOnStartupCheckBox->setChecked(config()->get("GUI/CheckForUpdates").toBool()); m_generalUi->checkForUpdatesIncludeBetasCheckBox->setChecked( @@ -272,7 +267,6 @@ void ApplicationSettingsWidget::saveSettings() config()->set("GUI/DarkTrayIcon", m_generalUi->systrayDarkIconCheckBox->isChecked()); config()->set("GUI/MinimizeToTray", m_generalUi->systrayMinimizeToTrayCheckBox->isChecked()); config()->set("GUI/MinimizeOnClose", m_generalUi->minimizeOnCloseCheckBox->isChecked()); - config()->set("GUI/QuietKeeShareSuccess", m_generalUi->quietKeeShareSuccess->isChecked()); config()->set("GUI/MinimizeOnStartup", m_generalUi->systrayMinimizeOnStartup->isChecked()); config()->set("GUI/CheckForUpdates", m_generalUi->checkForUpdatesOnStartupCheckBox->isChecked()); config()->set("GUI/CheckForUpdatesIncludeBetas", m_generalUi->checkForUpdatesIncludeBetasCheckBox->isChecked()); diff --git a/src/gui/ApplicationSettingsWidgetGeneral.ui b/src/gui/ApplicationSettingsWidgetGeneral.ui index c6ed54f9..784b8c7c 100644 --- a/src/gui/ApplicationSettingsWidgetGeneral.ui +++ b/src/gui/ApplicationSettingsWidgetGeneral.ui @@ -382,13 +382,6 @@ - - - - Do not show success notifications for KeeShare, only warnings and errors - - - diff --git a/src/gui/dbsettings/DatabaseSettingsDialog.cpp b/src/gui/dbsettings/DatabaseSettingsDialog.cpp index e0c59f10..e0e6765a 100644 --- a/src/gui/dbsettings/DatabaseSettingsDialog.cpp +++ b/src/gui/dbsettings/DatabaseSettingsDialog.cpp @@ -77,7 +77,7 @@ DatabaseSettingsDialog::DatabaseSettingsDialog(QWidget* parent) connect(m_ui->buttonBox, SIGNAL(rejected()), SLOT(reject())); m_ui->categoryList->addCategory(tr("General"), FilePath::instance()->icon("categories", "preferences-other")); - m_ui->categoryList->addCategory(tr("Security"), FilePath::instance()->icon("actions", "security-high")); + m_ui->categoryList->addCategory(tr("Security"), FilePath::instance()->icon("status", "security-high")); m_ui->stackedWidget->addWidget(m_generalWidget); m_ui->stackedWidget->addWidget(m_securityTabWidget); diff --git a/src/keeshare/SettingsWidgetKeeShare.cpp b/src/keeshare/SettingsWidgetKeeShare.cpp index c58e6dc9..0f33b1df 100644 --- a/src/keeshare/SettingsWidgetKeeShare.cpp +++ b/src/keeshare/SettingsWidgetKeeShare.cpp @@ -119,6 +119,8 @@ void SettingsWidgetKeeShare::saveSettings() KeeShare::setOwn(m_own); KeeShare::setForeign(m_foreign); KeeShare::setActive(active); + + config()->set("KeeShare/QuietSuccess", m_ui->quietSuccessCheckBox->isChecked()); } void SettingsWidgetKeeShare::setVerificationExporter(const QString& signer) diff --git a/src/keeshare/SettingsWidgetKeeShare.ui b/src/keeshare/SettingsWidgetKeeShare.ui index 93bd0fa1..77a9e3eb 100644 --- a/src/keeshare/SettingsWidgetKeeShare.ui +++ b/src/keeshare/SettingsWidgetKeeShare.ui @@ -29,6 +29,13 @@ Active + + + + Allow import + + + @@ -36,10 +43,13 @@ - - + + - Allow import + Only show warnings and errors + + + true diff --git a/src/keeshare/ShareObserver.cpp b/src/keeshare/ShareObserver.cpp index feff3829..7247db52 100644 --- a/src/keeshare/ShareObserver.cpp +++ b/src/keeshare/ShareObserver.cpp @@ -148,7 +148,7 @@ void ShareObserver::notifyAbout(const QStringList& success, const QStringList& w { QStringList messages; MessageWidget::MessageType type = MessageWidget::Positive; - if (!(success.isEmpty() || config()->get("GUI/QuietKeeShareSuccess").toBool())) { + if (!(success.isEmpty() || config()->get("KeeShare/QuietSuccess", true).toBool())) { messages += success; } if (!warning.isEmpty()) { @@ -219,8 +219,7 @@ ShareObserver::Result ShareObserver::importShare(const QString& path) const auto changePath = resolvePath(path, m_db); auto shareGroup = m_shareToGroup.value(changePath); if (!shareGroup) { - qWarning("Source for %s does not exist", qPrintable(path)); - Q_ASSERT(shareGroup); + qWarning("Group for %s does not exist", qPrintable(path)); return {}; } const auto reference = KeeShare::referenceOf(shareGroup);