jacobpascual/keepassxc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix keepassxc-browser password entropy display (#3107)

Browse Source 
* Pass correct entropy amount to keepassxc-browser instead of amount of bits for both password and passphrase.
* Rename json key from "login" to "entropy" (keeping "login" key for backwards compatibility).

* Also make some changes to entropy calculation methods:
  - Rename PassphraseGenerator::calculateEntropy to estimateEntropy
  - Rename PasswordGenerator::calculateEntropy to estimateEntropy
This commit is contained in:
AndrolGenhald
2019-06-19 19:40:41 -05:00
committed by Jonathan White
parent 7ceca8ff3c
commit e40f10657d
8 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/BrowserAction.cpp
View File

@@ -278,18 +278,18 @@ QJsonObject BrowserAction::handleGetLogins(const QJsonObject& json, const QStrin
QJsonObject BrowserAction::handleGeneratePassword(const QJsonObject& json, const QString& action)
{
const QString nonce = json.value("nonce").toString();
const QString password = browserSettings()->generatePassword();
auto nonce = json.value("nonce").toString();
auto password = browserSettings()->generatePassword();
if (nonce.isEmpty() || password.isEmpty()) {
return QJsonObject();
}
// For backwards compatibility
password["login"] = password["entropy"];
QJsonArray arr;
QJsonObject passwd;
passwd["login"] = QString::number(password.length() * 8); // bits;
passwd["password"] = password;
arr.append(passwd);
arr.append(password);
const QString newNonce = incrementNonce(nonce);