Implement Caps Lock warning

src/gui/PasswordEdit.cpp

@@ -22,16 +22,14 @@
 #include "core/Resources.h"
 #include "gui/Font.h"
 #include "gui/PasswordGeneratorWidget.h"
+#include "gui/osutils/OSUtils.h"
 #include "gui/styles/StateColorPalette.h"
 
 #include <QDialog>
+#include <QTimer>
+#include <QToolTip>
 #include <QVBoxLayout>
 
-namespace
-{
-
-} // namespace
-
 PasswordEdit::PasswordEdit(QWidget* parent)
     : QLineEdit(parent)
 {
@@ -70,6 +68,13 @@ PasswordEdit::PasswordEdit(QWidget* parent)
     m_passwordGeneratorAction->setShortcutContext(Qt::WidgetShortcut);
     addAction(m_passwordGeneratorAction, QLineEdit::TrailingPosition);
     m_passwordGeneratorAction->setVisible(false);
+
+    m_capslockAction =
+        new QAction(resources()->icon("dialog-warning", true, StateColorPalette().color(StateColorPalette::Error)),
+                    tr("Warning: Caps Lock enabled!"),
+                    nullptr);
+    addAction(m_capslockAction, QLineEdit::LeadingPosition);
+    m_capslockAction->setVisible(false);
 }
 
 void PasswordEdit::setRepeatPartner(PasswordEdit* repeatEdit)
@@ -165,3 +170,34 @@ void PasswordEdit::autocompletePassword(const QString& password)
         setText(password);
     }
 }
+
+bool PasswordEdit::event(QEvent* event)
+{
+    if (isVisible()) {
+        checkCapslockState();
+    }
+    return QLineEdit::event(event);
+}
+
+void PasswordEdit::checkCapslockState()
+{
+    if (m_parentPasswordEdit) {
+        return;
+    }
+
+    bool newCapslockState = osUtils->isCapslockEnabled();
+    if (newCapslockState != m_capslockState) {
+        m_capslockState = newCapslockState;
+        m_capslockAction->setVisible(newCapslockState);
+
+        // Force repaint to avoid rendering glitches of QLineEdit contents
+        repaint();
+
+        emit capslockToggled(m_capslockState);
+
+        if (newCapslockState) {
+            QTimer::singleShot(
+                150, [this]() { QToolTip::showText(mapToGlobal(rect().bottomLeft()), m_capslockAction->text()); });
+        }
+    }
+}

src/gui/PasswordEdit.h

@@ -39,20 +39,27 @@ public slots:
     void setShowPassword(bool show);
     void updateRepeatStatus();
 
+protected:
+    bool event(QEvent* event) override;
+
+signals:
+    void capslockToggled(bool capslockOn);
+
 private slots:
     void autocompletePassword(const QString& password);
     void popupPasswordGenerator();
     void setParentPasswordEdit(PasswordEdit* parent);
+    void checkCapslockState();
 
 private:
     QPointer<QAction> m_errorAction;
     QPointer<QAction> m_correctAction;
     QPointer<QAction> m_toggleVisibleAction;
     QPointer<QAction> m_passwordGeneratorAction;
+    QPointer<QAction> m_capslockAction;
     QPointer<PasswordEdit> m_repeatPasswordEdit;
     QPointer<PasswordEdit> m_parentPasswordEdit;
-    bool m_sendGeneratorSignal = false;
-    bool m_isRepeatPartner = false;
+    bool m_capslockState = false;
 };
 
 #endif // KEEPASSX_PASSWORDEDIT_H

src/gui/osutils/OSUtilsBase.h

@@ -31,6 +31,7 @@ class OSUtilsBase : public QObject
 
 public:
     virtual bool isDarkMode() = 0;
+    virtual bool isCapslockEnabled() = 0;
 
 protected:
     explicit OSUtilsBase(QObject* parent = nullptr);

src/gui/osutils/macutils/MacUtils.cpp

@@ -19,6 +19,9 @@
 #include "MacUtils.h"
 #include <QApplication>
 
+#include <CoreGraphics/CGEventSource.h>
+
+
 QPointer<MacUtils> MacUtils::m_instance = nullptr;
 
 MacUtils::MacUtils(QObject* parent)
@@ -85,3 +88,8 @@ bool MacUtils::enableScreenRecording()
 {
     return m_appkit->enableScreenRecording();
 }
+
+bool MacUtils::isCapslockEnabled()
+{
+    return (CGEventSourceFlagsState(kCGEventSourceStateHIDSystemState) & kCGEventFlagMaskAlphaShift) != 0;
+}

src/gui/osutils/macutils/MacUtils.h

@@ -33,13 +33,15 @@ class MacUtils : public OSUtilsBase
 public:
     static MacUtils* instance();
 
+    bool isDarkMode() override;
+    bool isCapslockEnabled() override;
+
     WId activeWindow();
     bool raiseWindow(WId pid);
     bool raiseLastActiveWindow();
     bool raiseOwnWindow();
     bool hideOwnWindow();
     bool isHidden();
-    bool isDarkMode() override;
     bool enableAccessibility();
     bool enableScreenRecording();
 

src/gui/osutils/nixutils/NixUtils.cpp

@@ -18,9 +18,17 @@
 #include "NixUtils.h"
 #include <QApplication>
 #include <QColor>
+#include <QGuiApplication>
 #include <QPalette>
 #include <QStyle>
 
+#include <qpa/qplatformnativeinterface.h>
+// namespace required to avoid name clashes with declarations in XKBlib.h
+namespace X11
+{
+#include <X11/XKBlib.h>
+}
+
 QPointer<NixUtils> NixUtils::m_instance = nullptr;
 
 NixUtils* NixUtils::instance()
@@ -48,3 +56,24 @@ bool NixUtils::isDarkMode()
     }
     return qApp->style()->standardPalette().color(QPalette::Window).toHsl().lightness() < 110;
 }
+
+bool NixUtils::isCapslockEnabled()
+{
+    QPlatformNativeInterface* native = QGuiApplication::platformNativeInterface();
+    auto* display = native->nativeResourceForWindow("display", nullptr);
+    if (!display) {
+        return false;
+    }
+
+    QString platform = QGuiApplication::platformName();
+    if (platform == "xcb") {
+        unsigned state = 0;
+        if (X11::XkbGetIndicatorState(reinterpret_cast<X11::Display*>(display), XkbUseCoreKbd, &state) == Success) {
+            return ((state & 1u) != 0);
+        }
+    }
+
+    // TODO: Wayland
+
+    return false;
+}

src/gui/osutils/nixutils/NixUtils.h

@@ -29,6 +29,7 @@ public:
     static NixUtils* instance();
 
     bool isDarkMode() override;
+    bool isCapslockEnabled() override;
 
 private:
     explicit NixUtils(QObject* parent = nullptr);

src/gui/osutils/winutils/WinUtils.cpp

@@ -83,3 +83,8 @@ bool WinUtils::isDarkMode()
                        QSettings::NativeFormat);
     return settings.value("AppsUseLightTheme", 1).toInt() == 0;
 }
+
+bool WinUtils::isCapslockEnabled()
+{
+    return GetKeyState(VK_CAPITAL) == 1;
+}

src/gui/osutils/winutils/WinUtils.h

@@ -33,6 +33,7 @@ public:
     static void registerEventFilters();
 
     bool isDarkMode() override;
+    bool isCapslockEnabled() override;
 
 protected:
     explicit WinUtils(QObject* parent = nullptr);