Fix GCC 8 memset warning and set -Werror only for debug builds, resolves #1558

2018-03-03 14:19:51 +01:00
parent 02b923b0e5
commit d3a80513a7
2 changed files with 10 additions and 2 deletions
--- a/src/http/Server.cpp
+++ b/src/http/Server.cpp
@@ -140,7 +140,11 @@ void Server::generatePassword(const Request &r, Response *protocolResp)
    protocolResp->setVerifier(key);
    protocolResp->setEntries(QList<Entry>() << Entry("generate-password", bits, password, "generate-password"));

-    memset(password.data(), 0, password.length());
+    int size = password.capacity();
+    volatile auto* mem = reinterpret_cast<volatile ushort*>(password.data());
+    while (size--) {
+        *mem++ = 0;
+    }
 }

 void Server::handleRequest(const QByteArray& data, QHttpResponse* response)