From d1793d9bcf519d99cd1d3d04aef1433743362bb3 Mon Sep 17 00:00:00 2001 From: Janek Bevendorff Date: Sat, 14 Jan 2017 21:09:59 +0200 Subject: [PATCH] Ask PR authors to remove lines that don't apply instead of changing emoji (#159) * Ask user to remove lines that don't apply instead of changing emoji * Replace KeePassXR with KeePassXC * Add help text how to find KeePassXC version [skip ci] * Combine documentation requirements into one [skip ci] --- .github/ISSUE_TEMPLATE.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 32 +++++++++++++++----------------- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 5ad51c74..1a3f1a06 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -26,7 +26,7 @@ ## Your Environment -* KeePassXR version/commit used: +* KeePassXC version/commit used: (can be found under Help -> About) * Qt version (e.g. Qt 5.3): * Compiler (e.g. Clang++3.6.0): * Operating System and version: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 51436aad..c83ca4e5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - + ## Description @@ -15,21 +15,19 @@ ## Screenshots (if appropriate): ## Types of changes - - - -- :negative_squared_cross_mark: Bug fix (non-breaking change which fixes an issue) -- :negative_squared_cross_mark: New feature (non-breaking change which adds functionality) -- :negative_squared_cross_mark: Breaking change (fix or feature that would cause existing functionality to change) + + +- ✅ Bug fix (non-breaking change which fixes an issue) +- ✅ New feature (non-breaking change which adds functionality) +- ✅ Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - - - - -- :negative_squared_cross_mark: I have read the **CONTRIBUTING** document. [REQUIRED] -- :negative_squared_cross_mark: My code follows the code style of this project. [REQUIRED] -- :negative_squared_cross_mark: All new and existing tests passed. [REQUIRED] -- :negative_squared_cross_mark: My change requires a change to the documentation. -- :negative_squared_cross_mark: I have updated the documentation accordingly. -- :negative_squared_cross_mark: I have added tests to cover my changes. + + + + +- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]** +- ✅ My code follows the code style of this project. **[REQUIRED]** +- ✅ All new and existing tests passed. **[REQUIRED]** +- ✅ My change requires a change to the documentation and I have updated it accordingly. +- ✅ I have added tests to cover my changes.