From cfe8ca983645f2bce100b5d970e109cbda377dd8 Mon Sep 17 00:00:00 2001 From: Janek Bevendorff Date: Sat, 20 Jan 2018 14:45:22 +0100 Subject: [PATCH] Always initialize m_httpClient to nullptr to avoid accidental dereferencing, resolves #1410 --- src/gui/EditWidgetIcons.cpp | 3 --- src/gui/EditWidgetIcons.h | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gui/EditWidgetIcons.cpp b/src/gui/EditWidgetIcons.cpp index 3ff036e3..6f5e7ee1 100644 --- a/src/gui/EditWidgetIcons.cpp +++ b/src/gui/EditWidgetIcons.cpp @@ -53,9 +53,6 @@ EditWidgetIcons::EditWidgetIcons(QWidget* parent) , m_fallbackToGoogle(true) , m_redirectCount(0) #endif -#ifdef WITH_XC_HTTP - , m_httpClient(nullptr) -#endif { m_ui->setupUi(this); diff --git a/src/gui/EditWidgetIcons.h b/src/gui/EditWidgetIcons.h index 0c155f7d..796dd593 100644 --- a/src/gui/EditWidgetIcons.h +++ b/src/gui/EditWidgetIcons.h @@ -97,7 +97,7 @@ private: QUrl m_redirectUrl; bool m_fallbackToGoogle; unsigned short m_redirectCount; - qhttp::client::QHttpClient* m_httpClient; + qhttp::client::QHttpClient* m_httpClient = nullptr; #endif Q_DISABLE_COPY(EditWidgetIcons)