jacobpascual/keepassxc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

some cppcheck and clang-tidy fixies

Browse Source
This commit is contained in:
asapelkin
2019-10-31 23:44:40 +03:00
committed by Jonathan White
parent ac7face247
commit 98badfb4a2
9 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/TestCsvParser.cpp
View File

@@ -111,7 +111,7 @@ void TestCsvParser::testEmptySimple()
out << "";
QVERIFY(parser->parse(file.data()));
t = parser->getCsvTable();
QVERIFY(t.size() == 0);
QVERIFY(t.isEmpty());
}
void TestCsvParser::testEmptyQuoted()
@@ -120,7 +120,7 @@ void TestCsvParser::testEmptyQuoted()
out << "\"\"";
QVERIFY(parser->parse(file.data()));
t = parser->getCsvTable();
QVERIFY(t.size() == 0);
QVERIFY(t.isEmpty());
}
void TestCsvParser::testEmptyNewline()
@@ -129,14 +129,14 @@ void TestCsvParser::testEmptyNewline()
out << "\"\n\"";
QVERIFY(parser->parse(file.data()));
t = parser->getCsvTable();
QVERIFY(t.size() == 0);
QVERIFY(t.isEmpty());
}
void TestCsvParser::testEmptyFile()
{
QVERIFY(parser->parse(file.data()));
t = parser->getCsvTable();
QVERIFY(t.size() == 0);
QVERIFY(t.isEmpty());
}
void TestCsvParser::testNewline()
@@ -281,7 +281,7 @@ void TestCsvParser::testEmptyReparsing()
parser->parse(nullptr);
QVERIFY(parser->reparse());
t = parser->getCsvTable();
QVERIFY(t.size() == 0);
QVERIFY(t.isEmpty());
}
void TestCsvParser::testReparsing()

4
tests/TestEntryModel.cpp
View File

@@ -296,7 +296,7 @@ void TestEntryModel::testProxyModel()
QSignalSpy spyColumnRemove(modelProxy, SIGNAL(columnsAboutToBeRemoved(QModelIndex, int, int)));
modelProxy->hideColumn(0, true);
QCOMPARE(modelProxy->columnCount(), 12);
QVERIFY(spyColumnRemove.size() >= 1);
QVERIFY(!spyColumnRemove.isEmpty());
int oldSpyColumnRemoveSize = spyColumnRemove.size();
modelProxy->hideColumn(0, true);
@@ -318,7 +318,7 @@ void TestEntryModel::testProxyModel()
QSignalSpy spyColumnInsert(modelProxy, SIGNAL(columnsAboutToBeInserted(QModelIndex, int, int)));
modelProxy->hideColumn(0, false);
QCOMPARE(modelProxy->columnCount(), 13);
QVERIFY(spyColumnInsert.size() >= 1);
QVERIFY(!spyColumnInsert.isEmpty());
int oldSpyColumnInsertSize = spyColumnInsert.size();
modelProxy->hideColumn(0, false);

2
tests/TestGroup.cpp
View File

@@ -1070,7 +1070,7 @@ void TestGroup::testHierarchy()
QVERIFY(hierarchy.contains("group3"));
hierarchy = group3->hierarchy(0);
QVERIFY(hierarchy.size() == 0);
QVERIFY(hierarchy.isEmpty());
hierarchy = group3->hierarchy(1);
QVERIFY(hierarchy.size() == 1);