From 82cb31597745349ce38f27835d68782f12c3532e Mon Sep 17 00:00:00 2001 From: Felix Geyer Date: Wed, 25 Aug 2010 14:00:46 +0200 Subject: [PATCH] Implement some const methods properly. --- src/core/Group.cpp | 18 ++++-------------- src/core/Group.h | 4 ++-- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/src/core/Group.cpp b/src/core/Group.cpp index 1982cde1..0aaceb12 100644 --- a/src/core/Group.cpp +++ b/src/core/Group.cpp @@ -248,14 +248,9 @@ QList Group::children() return m_children; } -QList Group::children() const +const QList& Group::children() const { - QList constChildren; - Q_FOREACH (Group* group, m_children) { - constChildren << group; - } - - return constChildren; + return m_children; } QList Group::entries() @@ -263,14 +258,9 @@ QList Group::entries() return m_entries; } -QList Group::entries() const +const QList& Group::entries() const { - QList constEntries; - Q_FOREACH (Entry* entry, m_entries) { - constEntries << entry; - } - - return constEntries; + return m_entries; } void Group::addEntry(Entry *entry) diff --git a/src/core/Group.h b/src/core/Group.h index 4b46a9ff..14cf33f2 100644 --- a/src/core/Group.h +++ b/src/core/Group.h @@ -65,9 +65,9 @@ public: const Database* database() const; QList children(); - QList children() const; + const QList& children() const; QList entries(); - QList entries() const; + const QList& entries() const; void addEntry(Entry* entry); void removeEntry(Entry* entry);