From 7a823e8dc7d2f149b51036dd918e66deef9affd9 Mon Sep 17 00:00:00 2001
From: Gianluca Recchia <gianluca.recchia97@gmail.com>
Date: Sat, 27 Oct 2018 04:38:10 +0200
Subject: [PATCH] Pin AutoTypeAction's vtable to a translation unit

AutoTypeAction class had no out-of-line definitions and because of this
the compiler would place its vtable everywhere the class is used.
By simply defining the virtual destructor in the .cpp file, the issue
goes away.

Also, a few classes derived from AutoTypeAction had missing 'override'
qualifiers, which have now been added.
---
 src/autotype/AutoTypeAction.cpp |  6 ++++++
 src/autotype/AutoTypeAction.h   | 20 +++++++++-----------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/src/autotype/AutoTypeAction.cpp b/src/autotype/AutoTypeAction.cpp
index 0beb19b3..f9d928f0 100644
--- a/src/autotype/AutoTypeAction.cpp
+++ b/src/autotype/AutoTypeAction.cpp
@@ -87,3 +87,9 @@ void AutoTypeExecutor::execClearField(AutoTypeClearField* action)
 {
     Q_UNUSED(action);
 }
+
+AutoTypeAction::~AutoTypeAction()
+{
+    // This makes sure that AutoTypeAction's vtable is placed
+    // in this translation unit.
+}
diff --git a/src/autotype/AutoTypeAction.h b/src/autotype/AutoTypeAction.h
index 263566dd..e598b1dc 100644
--- a/src/autotype/AutoTypeAction.h
+++ b/src/autotype/AutoTypeAction.h
@@ -29,19 +29,17 @@ class AutoTypeExecutor;
 class KEEPASSX_EXPORT AutoTypeAction
 {
 public:
-    virtual ~AutoTypeAction()
-    {
-    }
     virtual AutoTypeAction* clone() = 0;
     virtual void accept(AutoTypeExecutor* executor) = 0;
+    virtual ~AutoTypeAction();
 };
 
 class KEEPASSX_EXPORT AutoTypeChar : public AutoTypeAction
 {
 public:
     explicit AutoTypeChar(const QChar& character);
-    AutoTypeAction* clone();
-    void accept(AutoTypeExecutor* executor);
+    AutoTypeAction* clone() override;
+    void accept(AutoTypeExecutor* executor) override;
 
     const QChar character;
 };
@@ -50,8 +48,8 @@ class KEEPASSX_EXPORT AutoTypeKey : public AutoTypeAction
 {
 public:
     explicit AutoTypeKey(Qt::Key key);
-    AutoTypeAction* clone();
-    void accept(AutoTypeExecutor* executor);
+    AutoTypeAction* clone() override;
+    void accept(AutoTypeExecutor* executor) override;
 
     const Qt::Key key;
 };
@@ -60,8 +58,8 @@ class KEEPASSX_EXPORT AutoTypeDelay : public AutoTypeAction
 {
 public:
     explicit AutoTypeDelay(int delayMs);
-    AutoTypeAction* clone();
-    void accept(AutoTypeExecutor* executor);
+    AutoTypeAction* clone() override;
+    void accept(AutoTypeExecutor* executor) override;
 
     const int delayMs;
 };
@@ -70,8 +68,8 @@ class KEEPASSX_EXPORT AutoTypeClearField : public AutoTypeAction
 {
 public:
     AutoTypeClearField();
-    AutoTypeAction* clone();
-    void accept(AutoTypeExecutor* executor);
+    AutoTypeAction* clone() override;
+    void accept(AutoTypeExecutor* executor) override;
 };
 
 class KEEPASSX_EXPORT AutoTypeExecutor