From 564188b0d3ef80e436a66c4f53f0393b1cfcfd08 Mon Sep 17 00:00:00 2001 From: angelsl Date: Mon, 13 Nov 2017 03:20:37 +0800 Subject: [PATCH] Report database read failure reason in tests --- tests/TestKeePass2Writer.cpp | 7 +++++-- tests/TestKeys.cpp | 9 ++++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/TestKeePass2Writer.cpp b/tests/TestKeePass2Writer.cpp index 049c3e66..30d0cbf5 100644 --- a/tests/TestKeePass2Writer.cpp +++ b/tests/TestKeePass2Writer.cpp @@ -65,12 +65,15 @@ void TestKeePass2Writer::initTestCase() buffer.open(QBuffer::ReadWrite); KeePass2Writer writer; - writer.writeDatabase(&buffer, m_dbOrg); + bool writeSuccess = writer.writeDatabase(&buffer, m_dbOrg); + QVERIFY(writeSuccess); QVERIFY(!writer.hasError()); buffer.seek(0); KeePass2Reader reader; m_dbTest = reader.readDatabase(&buffer, key); - QVERIFY(!reader.hasError()); + if (reader.hasError()) { + QFAIL(reader.errorString().toUtf8().constData()); + } QVERIFY(m_dbTest); } diff --git a/tests/TestKeys.cpp b/tests/TestKeys.cpp index 990878e2..a97287f3 100644 --- a/tests/TestKeys.cpp +++ b/tests/TestKeys.cpp @@ -153,12 +153,19 @@ void TestKeys::testCreateAndOpenFileKey() KeePass2Writer writer; writer.writeDatabase(&dbBuffer, dbOrg.data()); + bool writeSuccess = writer.writeDatabase(&dbBuffer, dbOrg.data()); + if (writer.hasError()) { + QFAIL(writer.errorString().toUtf8().constData()); + } + QVERIFY(writeSuccess); dbBuffer.reset(); KeePass2Reader reader; QScopedPointer dbRead(reader.readDatabase(&dbBuffer, compositeKey)); + if (reader.hasError()) { + QFAIL(reader.errorString().toUtf8().constData()); + } QVERIFY(dbRead); - QVERIFY(!reader.hasError()); QCOMPARE(dbRead->metadata()->name(), dbName); }