jacobpascual/keepassxc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve performance of a few for-loops

Browse Source 
Some for-loops needlessly copied the collection they were looping over.
This commit is contained in:
Gianluca Recchia
2018-10-27 23:23:34 +02:00
parent e2ee82169c
commit 4876beabed
5 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/Group.cpp
View File

@@ -926,7 +926,7 @@ bool Group::resolveAutoTypeEnabled() const
}
}
QStringList Group::locate(QString locateTerm, QString currentPath)
QStringList Group::locate(QString locateTerm, QString currentPath) const
{
// TODO: Replace with EntrySearcher
QStringList response;
@@ -934,15 +934,15 @@ QStringList Group::locate(QString locateTerm, QString currentPath)
return response;
}
for (Entry* entry : asConst(m_entries)) {
for (const Entry* entry : asConst(m_entries)) {
QString entryPath = currentPath + entry->title();
if (entryPath.toLower().contains(locateTerm.toLower())) {
response << entryPath;
}
}
for (Group* group : asConst(m_children)) {
for (QString path : group->locate(locateTerm, currentPath + group->name() + QString("/"))) {
for (const Group* group : asConst(m_children)) {
for (const QString& path : group->locate(locateTerm, currentPath + group->name() + QString("/"))) {
response << path;
}
}