From 3ffeab4c41ac79a5426e1736301f979ae4abe41f Mon Sep 17 00:00:00 2001 From: Peifeng Yu Date: Wed, 11 Dec 2019 16:52:11 -0500 Subject: [PATCH] FdoSecrets: fix all exposed entries are returned if search with empty terms --- src/fdosecrets/objects/Collection.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/fdosecrets/objects/Collection.cpp b/src/fdosecrets/objects/Collection.cpp index ef277e89..b8708aa2 100644 --- a/src/fdosecrets/objects/Collection.cpp +++ b/src/fdosecrets/objects/Collection.cpp @@ -242,6 +242,11 @@ namespace FdoSecrets terms << attributeToTerm(it.key(), it.value()); } + // empty terms causes EntrySearcher returns everything + if (terms.isEmpty()) { + return QList{}; + } + QList items; const auto foundEntries = EntrySearcher().search(terms, m_exposedGroup); items.reserve(foundEntries.size());