diff --git a/src/gui/SearchWidget.cpp b/src/gui/SearchWidget.cpp index 5edf17cd..60adaf76 100644 --- a/src/gui/SearchWidget.cpp +++ b/src/gui/SearchWidget.cpp @@ -34,12 +34,11 @@ SearchWidget::SearchWidget(QWidget *parent) m_searchTimer->setSingleShot(true); connect(m_ui->searchEdit, SIGNAL(textChanged(QString)), SLOT(startSearchTimer())); - connect(m_ui->searchEdit, SIGNAL(returnPressed()), SLOT(startSearch())); connect(m_ui->searchIcon, SIGNAL(triggered(QAction*)), m_ui->searchEdit, SLOT(setFocus())); connect(m_searchTimer, SIGNAL(timeout()), this, SLOT(startSearch())); connect(this, SIGNAL(escapePressed()), m_ui->searchEdit, SLOT(clear())); - new QShortcut(Qt::CTRL + Qt::Key_F, m_ui->searchEdit, SLOT(setFocus()), nullptr, Qt::ApplicationShortcut); + new QShortcut(Qt::CTRL + Qt::Key_F, this, SLOT(searchFocus()), nullptr, Qt::ApplicationShortcut); m_ui->searchEdit->installEventFilter(this); @@ -76,14 +75,9 @@ bool SearchWidget::eventFilter(QObject *obj, QEvent *event) } } else if (keyEvent->matches(QKeySequence::MoveToNextLine)) { - // If Down is pressed at EOL in the search edit, move - // the focus to the entry view. - QLineEdit* searchEdit = m_ui->searchEdit; - if (!searchEdit->hasSelectedText() && - searchEdit->cursorPosition() == searchEdit->text().length()) { - emit downPressed(); - return true; - } + // If Down is pressed move the focus to the entry view. + emit downPressed(); + return true; } } @@ -96,6 +90,7 @@ void SearchWidget::connectSignals(SignalMultiplexer& mx) mx.connect(this, SIGNAL(caseSensitiveChanged(bool)), SLOT(setSearchCaseSensitive(bool))); mx.connect(this, SIGNAL(copyPressed()), SLOT(copyPassword())); mx.connect(this, SIGNAL(downPressed()), SLOT(setFocus())); + mx.connect(m_ui->searchEdit, SIGNAL(returnPressed()), SLOT(switchToEntryEdit())); } void SearchWidget::databaseChanged(DatabaseWidget *dbWidget) @@ -138,3 +133,9 @@ void SearchWidget::setCaseSensitive(bool state) m_actionCaseSensitive->setChecked(state); updateCaseSensitive(); } + +void SearchWidget::searchFocus() +{ + m_ui->searchEdit->setFocus(); + m_ui->searchEdit->selectAll(); +} diff --git a/src/gui/SearchWidget.h b/src/gui/SearchWidget.h index 01f9e536..d2b94d97 100644 --- a/src/gui/SearchWidget.h +++ b/src/gui/SearchWidget.h @@ -48,6 +48,7 @@ signals: void escapePressed(); void copyPressed(); void downPressed(); + void enterPressed(); public slots: void databaseChanged(DatabaseWidget* dbWidget); @@ -56,6 +57,7 @@ private slots: void startSearchTimer(); void startSearch(); void updateCaseSensitive(); + void searchFocus(); private: const QScopedPointer m_ui; diff --git a/tests/gui/TestGui.cpp b/tests/gui/TestGui.cpp index babab8ab..45c1a271 100644 --- a/tests/gui/TestGui.cpp +++ b/tests/gui/TestGui.cpp @@ -413,19 +413,26 @@ void TestGui::testSearch() // Search for "someTHING" QTest::keyClicks(searchTextEdit, "THING"); QTRY_COMPARE(entryView->model()->rowCount(), 2); - // Press Down to focus on the entry view if at EOL + // Press Down to focus on the entry view QTest::keyClick(searchTextEdit, Qt::Key_Right, Qt::ControlModifier); QTRY_VERIFY(searchTextEdit->hasFocus()); QTest::keyClick(searchTextEdit, Qt::Key_Down); QTRY_VERIFY(entryView->hasFocus()); - // Test clipboard + // Restore focus and search text selection + QTest::keyClick(m_mainWindow, Qt::Key_F, Qt::ControlModifier); + QTRY_COMPARE(searchTextEdit->selectedText(), QString("someTHING")); + // Ensure Down focuses on entry view when search text is selected + QTest::keyClick(searchTextEdit, Qt::Key_Down); + QTRY_VERIFY(entryView->hasFocus()); + // Refocus back to search edit + QTest::mouseClick(searchTextEdit, Qt::LeftButton); + QTRY_VERIFY(searchTextEdit->hasFocus()); + // Test password copy QClipboard *clipboard = QApplication::clipboard(); - QTest::keyClick(entryView, Qt::Key_C, Qt::ControlModifier); + QTest::keyClick(searchTextEdit, Qt::Key_C, Qt::ControlModifier); QModelIndex searchedItem = entryView->model()->index(0, 1); Entry* searchedEntry = entryView->entryFromIndex(searchedItem); QTRY_COMPARE(searchedEntry->password(), clipboard->text()); - // Restore focus - QTest::mouseClick(searchTextEdit, Qt::LeftButton); // Test case sensitive search searchWidget->setCaseSensitive(true); @@ -445,16 +452,14 @@ void TestGui::testSearch() QCOMPARE(groupView->currentGroup(), m_db->rootGroup()); // Try to edit the first entry from the search view + // Refocus back to search edit + QTest::mouseClick(searchTextEdit, Qt::LeftButton); + QTRY_VERIFY(searchTextEdit->hasFocus()); + QVERIFY(m_dbWidget->isInSearchMode()); + QModelIndex item = entryView->model()->index(0, 1); Entry* entry = entryView->entryFromIndex(item); - QVERIFY(m_dbWidget->isInSearchMode()); - clickIndex(item, entryView, Qt::LeftButton); - QAction* entryEditAction = m_mainWindow->findChild("actionEntryEdit"); - QVERIFY(entryEditAction->isEnabled()); - QWidget* entryEditWidget = toolBar->widgetForAction(entryEditAction); - QVERIFY(entryEditWidget->isVisible()); - QVERIFY(entryEditWidget->isEnabled()); - QTest::mouseClick(entryEditWidget, Qt::LeftButton); + QTest::keyClick(searchTextEdit, Qt::Key_Return); QCOMPARE(m_dbWidget->currentMode(), DatabaseWidget::EditMode); // Perform the edit and save it @@ -465,7 +470,7 @@ void TestGui::testSearch() QDialogButtonBox* editEntryWidgetButtonBox = editEntryWidget->findChild("buttonBox"); QTest::mouseClick(editEntryWidgetButtonBox->button(QDialogButtonBox::Ok), Qt::LeftButton); - // Confirm the edit was made and we are back in view mode + // Confirm the edit was made and we are back in search mode QTRY_VERIFY(m_dbWidget->isInSearchMode()); QCOMPARE(entry->title(), origTitle.append("_edited"));