jacobpascual/keepassxc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code quality updates for 2.4.0 (#2709)

Browse Source 
* Minor code quality fixes found by Codacy
* Fix unused variables when WITH_XC_NETWORKING is OFF
* Fix #2684, resolve entry references from the root group
* Fix #2697 and Fix #2699, listen specifically for 
WM_QUERYENDSESSION and WM_ENDSESSION on 
Windows to gracefully shutdown KeePassXC
* Cleanup proxy code and add explicit closure for
shutdown messages
This commit is contained in:
Jonathan White
2019-02-18 08:26:56 -05:00
committed by GitHub
parent fa3c959212
commit 0c587999c6
15 changed files with 97 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/proxy/NativeMessagingHost.cpp
View File

@@ -19,7 +19,7 @@
#include <QCoreApplication>
#ifdef Q_OS_WIN
#include <Winsock2.h>
#include <winsock2.h>
#endif
NativeMessagingHost::NativeMessagingHost()
@@ -36,14 +36,12 @@ NativeMessagingHost::NativeMessagingHost()
}
#ifdef Q_OS_WIN
m_running.store(true);
m_future =
QtConcurrent::run(this, static_cast<void (NativeMessagingHost::*)()>(&NativeMessagingHost::readNativeMessages));
m_future = QtConcurrent::run(this, &NativeMessagingHost::readNativeMessages);
#endif
connect(m_localSocket, SIGNAL(readyRead()), this, SLOT(newLocalMessage()));
connect(m_localSocket, SIGNAL(disconnected()), this, SLOT(deleteSocket()));
connect(m_localSocket,
SIGNAL(stateChanged(QLocalSocket::LocalSocketState)),
this,
SLOT(socketStateChanged(QLocalSocket::LocalSocketState)));
}