Code quality updates for 2.4.0 (#2709)

* Minor code quality fixes found by Codacy
* Fix unused variables when WITH_XC_NETWORKING is OFF
* Fix #2684, resolve entry references from the root group
* Fix #2697 and Fix #2699, listen specifically for 
WM_QUERYENDSESSION and WM_ENDSESSION on 
Windows to gracefully shutdown KeePassXC
* Cleanup proxy code and add explicit closure for
shutdown messages
This commit is contained in:
Jonathan White
2019-02-18 08:26:56 -05:00
committed by GitHub
parent fa3c959212
commit 0c587999c6
15 changed files with 97 additions and 46 deletions

View File

@@ -53,7 +53,7 @@ protected slots:
protected:
virtual void readLength() = 0;
virtual bool readStdIn(const quint32 length) = 0;
void readNativeMessages();
virtual void readNativeMessages();
QString jsonToString(const QJsonObject& json) const;
void sendReply(const QJsonObject& json);
void sendReply(const QString& reply);

View File

@@ -32,7 +32,7 @@ class NativeMessagingHost : public NativeMessagingBase
public:
explicit NativeMessagingHost(DatabaseTabWidget* parent = nullptr, const bool enabled = false);
~NativeMessagingHost();
~NativeMessagingHost() override;
int init();
void run();
void stop();